[GitHub] igreenfield commented on issue #23169: [SPARK-26103][SQL] Limit the length of debug strings for query plans

[GitBox]

igreenfield commented on issue #23169: [SPARK-26103][SQL] Limit the length of 
debug strings for query plans
URL: https://github.com/apache/spark/pull/23169#issuecomment-455313485
 
 
   @DaveDeCaprio First thanks for taking that fix!!
   second:
   
   The plan description is created in any case buy this code: 
`queryExecution.toString`
   
   object SQLExecution {
   ...
   withSQLConfPropagated(sparkSession) {
           sc.listenerBus.post(SparkListenerSQLExecutionStart(
             executionId, callSite.shortForm, callSite.longForm, 
queryExecution.toString,
             SparkPlanInfo.fromSparkPlan(queryExecution.executedPlan), 
System.currentTimeMillis()))
           try {
             body
           } finally {
             sc.listenerBus.post(SparkListenerSQLExecutionEnd(
               executionId, System.currentTimeMillis()))
           }
         }
       } finally {
         executionIdToQueryExecution.remove(executionId)
         sc.setLocalProperty(EXECUTION_ID_KEY, oldExecutionId)
       }
   ...
   }
   so the new PR will solve one issue: Memory usage. but the working down the 
tree to create unneeded string will still happen and waste the time of 
execution...
   
   can't this be lazily created if needed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org