HyukjinKwon commented on a change in pull request #23582: [SPARK-26661][SQL]
Show actual class name of the writing command in CTAS explain
URL: https://github.com/apache/spark/pull/23582#discussion_r248979249
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
##########
@@ -83,10 +84,12 @@ trait CreateHiveTableAsSelectBase extends
DataWritingCommand {
tableDesc: CatalogTable,
tableExists: Boolean): DataWritingCommand
+ def writingCommandClass: Class[_]
+
override def argString(maxFields: Int): String = {
s"[Database:${tableDesc.database}, " +
s"TableName: ${tableDesc.identifier.table}, " +
- s"InsertIntoHiveTable]"
+ s"${Utils.getSimpleName(writingCommandClass)}]"
Review comment:
I think we could simply `Utils.getSimpleName(this.getClass)}`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
