inpefess commented on a change in pull request #20691: [SPARK-18161] [Python] 
Update cloudpickle to v0.6.1
URL: https://github.com/apache/spark/pull/20691#discussion_r249093196
 
 

 ##########
 File path: python/pyspark/cloudpickle.py
 ##########
 @@ -72,6 +78,22 @@
     PY3 = True
 
 Review comment:
   > Is this reversed? looks like this is meant to be true when running Python 
3? (I know you didn't change it here)
   
   Can you state it more precisely? What I see is `PY3 = True` is executed when 
`sys.version < '3'` is False --- that's OK.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to