srowen commented on issue #23585: [SPARK-26662][CORE] Dispose off-heap memory when MemoryStore is cleared URL: https://github.com/apache/spark/pull/23585#issuecomment-455606201 I don't know this code well, but it looks reasonable to me. I suppose the only drawback is the extra work to dispose these upfront? but seems like good hygiene.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
