srowen commented on issue #23549: [SPARK-26616][MLlib] Expose document 
frequency in IDFModel
URL: https://github.com/apache/spark/pull/23549#issuecomment-455611605
 
 
   Ignore the 'merge cleanly' message; I think it's caused by another error. It 
is mergeable.
   
   You can suppress the DocumentFrequencyAggregator MiMa warning as the error 
indicates, because that's a private class and we can change it.
   
   The IDFModel constructor is actually also private, though MiMa doesn't know 
that. You can suppress it too. Yes we could add back the constructor and 
deprecate it, but I don't see a compelling reason for it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to