[GitHub] shahidki31 commented on a change in pull request #23589: [SPARK-26351][mllib]Update doc and minor correction in the mllib evaluation metrics

Sat, 19 Jan 2019 08:13:35 -0800 

shahidki31 commented on a change in pull request #23589: 
[SPARK-26351][mllib]Update doc and minor correction in the mllib evaluation 
metrics
URL: https://github.com/apache/spark/pull/23589#discussion_r249249176
 
 

 ##########
 File path: 
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RankingMetrics.scala
 ##########
 @@ -100,7 +100,7 @@ class RankingMetrics[T: ClassTag](predictionAndLabels: 
RDD[(Array[T], Array[T])]
           }
           i += 1
         }
-        precSum / labSet.size
+        precSum / n
 
 Review comment:
   Yes, you are right. I was confused with the "Q" in the formula. I will 
update.
   ![screenshot from 2019-01-19 
21-41-44](https://user-images.githubusercontent.com/23054875/51429276-1142a180-1c33-11e9-8459-d80137b99569.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to