dongjoon-hyun commented on a change in pull request #23582: [SPARK-26661][SQL]
Show actual class name of the writing command in CTAS explain
URL: https://github.com/apache/spark/pull/23582#discussion_r249254525
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
##########
@@ -83,10 +84,14 @@ trait CreateHiveTableAsSelectBase extends
DataWritingCommand {
tableDesc: CatalogTable,
tableExists: Boolean): DataWritingCommand
+ // A subclass should override this with the Class of the concrete type
expected to be
+ // returned from `getWritingCommand`.
+ def writingCommandClass: Class[_]
Review comment:
In general, we had better minimize the surface of API in terms of
`parameters` and `return values`. As we know, `Class[_]` has much more
information than `String`(name).
And, Yes. Since I also received the same feedbacks during working on APIs in
the Spark community, I have a strong preference to avoid excessive information
exposure. Is there any future plan to use that function for the other purpose?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
