Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/3409#discussion_r21309157
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -360,6 +360,10 @@ private[spark] trait ClientBase extends Logging {
}
}
+ // include yarn am specific java options
+ sparkConf.getOption("spark.yarn.am.extraJavaOptions")
+ .foreach(opts => javaOpts += opts)
--- End diff --
so currently this affects both cluster and client mode since
driver.extraJavaOptions applies in cluster mode I think we should make this
only apply in client mode. Otherwise we should define precendence between it
and the driver.extraJavaOptions in driver mode or potentially error if they
aren't set. It seems most straight forward to only have it apply in client
mode but I'm open to thoughts - @vanzin @andrewor14 .
Also we should run this through the check like in SparkConf for
spark.executor.extraJavaOptions to make sure no spark configs or -Xmx is set.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
