HyukjinKwon commented on a change in pull request #23559: [SPARK-26630][SQL]
Fix ClassCastException in TableReader while creating HadoopRDD
URL: https://github.com/apache/spark/pull/23559#discussion_r249274532
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala
##########
@@ -288,29 +285,105 @@ class HadoopTableReader(
}
}
+ /**
+ * The entry of creating a RDD.
+ */
+ private def getRDD(
+ inputClassName: String,
+ localTableDesc: TableDesc,
+ inputPathStr: String): RDD[Writable] = {
+ if (isCreateNewHadoopRDD(inputClassName)) {
+ createNewHadoopRdd(
+ localTableDesc,
+ inputPathStr,
+ inputClassName)
+ } else {
+ createHadoopRdd(
+ localTableDesc,
+ inputPathStr,
+ inputClassName)
Review comment:
I think we can make it inlined.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
