srowen commented on a change in pull request #23416: [SPARK-26463][CORE] Use 
ConfigEntry for hardcoded configs for scheduler categories.
URL: https://github.com/apache/spark/pull/23416#discussion_r249286233
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/ui/jobs/JobsTab.scala
 ##########
 @@ -37,7 +38,7 @@ private[ui] class JobsTab(parent: SparkUI, store: 
AppStatusStore)
     store
       .environmentInfo()
       .sparkProperties
-      .contains(("spark.scheduler.mode", SchedulingMode.FAIR.toString))
+      .contains((SCHEDULER_MODE.key, SchedulingMode.FAIR.toString))
 
 Review comment:
   I see, .sparkProperties is a `Seq[(String, String)]`. Elsewhere it's 
converted to a Map to query it, but that seems like overkill

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to