HyukjinKwon commented on a change in pull request #23596: [SPARK-26652] Use
Proleptic Gregorian Calendar in Literal.fromString
URL: https://github.com/apache/spark/pull/23596#discussion_r249286784
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
##########
@@ -139,6 +141,11 @@ object Literal {
* Constructs a Literal from a String
*/
def fromString(str: String, dataType: DataType): Literal = {
Review comment:
Is there an explicit plan to use this somewhere? If so, that's okay.
Otherwise, let's remove. In general, we shouldn't keep the codes for
internal purpose that are not being called. Removed codes remaining in the
commit and other branches - we can always revive them when it's actually used
or in order to deduplicate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
