srowen commented on a change in pull request #23592: [SPARK-16838][PYTHON]Add
PMML export for ML KMeans in PySpark
URL: https://github.com/apache/spark/pull/23592#discussion_r249288937
##########
File path: python/pyspark/ml/clustering.py
##########
@@ -323,7 +323,7 @@ def trainingCost(self):
return self._call_java("trainingCost")
-class KMeansModel(JavaModel, JavaMLWritable, JavaMLReadable):
+class KMeansModel(JavaModel, GeneralJavaMLWritable, JavaMLReadable):
Review comment:
I see, this is all we need because the Scala implementation already
implements `GeneralMLWritable`? sounds good as this is what
LinearRegressionModel does too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
