kiszk commented on issue #23497: [SPARK-26578][CORE] Synchronize putBytes's memory allocation and putting block on memoryManager URL: https://github.com/apache/spark/pull/23497#issuecomment-455890439 Sorry for my late comments. Here are my comments @SongYadong > Nested synchronized here may not cause deadlock beacuse they synchronize on the same lock We see different monitors (`memoryManager` and `entries`) in this PR > Could this avoid some data inconsistency? If it is true, how about `putIterator`? @sowen > However none of the entries.synchronized blocks acquire the memoryStore lock Thank you for your confirmation. > The 'allocation' method locks the memoryStore the whole time while the 'eviction' method doesn't. I think the current steps look conservative (I mean that it aquires memory, but not add an entry for a short time). I think that it could work.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
