MaxGekk commented on a change in pull request #23596: [SPARK-26652] Use
Proleptic Gregorian Calendar in Literal.fromString
URL: https://github.com/apache/spark/pull/23596#discussion_r249293408
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/LiteralExpressionSuite.scala
##########
@@ -243,7 +243,7 @@ class LiteralExpressionSuite extends SparkFunSuite with
ExpressionEvalHelper {
checkEvaluation(Literal.fromString("Databricks", StringType), "Databricks")
val dateString = "1970-01-01"
checkEvaluation(Literal.fromString(dateString, DateType),
java.sql.Date.valueOf(dateString))
- val timestampString = "0000-01-01 00:00:00"
Review comment:
I would say it is bug fix. I guess old (current) implementation wasn't
strong enough in checking its input.
Year zero does not exists in current (common) era (CE) and before common era
(BCE) as well (see https://en.wikipedia.org/wiki/Year_zero).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
