maropu commented on a change in pull request #23559: [SPARK-26630][SQL] Fix
ClassCastException in TableReader while creating HadoopRDD
URL: https://github.com/apache/spark/pull/23559#discussion_r249315479
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala
##########
@@ -289,15 +287,28 @@ class HadoopTableReader(
}
/**
- * Creates a HadoopRDD based on the broadcasted HiveConf and other job
properties that will be
+ * The entry of creating a RDD.
+ */
+ private def createHadoopRDD(
+ inputClassName: String, localTableDesc: TableDesc, inputPathStr:
String): RDD[Writable] = {
+ if (classOf[org.apache.hadoop.mapreduce.InputFormat[_, _]]
Review comment:
Probably, @srowen meant you'd be better to just write...;
```
// Create local references so that the outer object isn't serialized.
val localTableDesc = tableDesc
partDesc.getInputFileFormatClass match {
case c: Class[_] if c ==
classOf[org.apache.hadoop.mapreduce.InputFormat[_, _]] =>
createNewHadoopRdd(...)
case _ =>
createOldadoopRdd(...)
}
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
