HeartSaVioR commented on a change in pull request #23576: [SPARK-26655] [SS]
Support multiple aggregates in append mode
URL: https://github.com/apache/spark/pull/23576#discussion_r249301411
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
##########
@@ -96,20 +96,20 @@ object UnsupportedOperationChecker {
// Disallow some output mode
outputMode match {
case InternalOutputModes.Append if aggregates.nonEmpty =>
- val aggregate = aggregates.head
-
- // Find any attributes that are associated with an eventTime watermark.
- val watermarkAttributes = aggregate.groupingExpressions.collect {
- case a: Attribute if
a.metadata.contains(EventTimeWatermark.delayKey) => a
- }
+ aggregates.foreach(aggregate => {
Review comment:
nit: `foreach { aggregate =>`
https://github.com/databricks/scala-style-guide/blob/master/README.md#anonymous-methods
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
