HyukjinKwon commented on issue #23588: Diversity URL: https://github.com/apache/spark/pull/23588#issuecomment-455952639 I think you bought it first https://github.com/apache/spark/pull/23588#issuecomment-455819321 and I said to read it. The cost of merging it - it gives an example that those changes are encouraged. This PR itself isn't welcomed. See the description, title and what it proposes. Second, it costs Jenkins resource which is limited. When it runs multiple builds, it causes a global test failure which blocks all other PRs. Lastly reviewing cost. I would need to check if there are similar instances to fix at least. Additionally merging it as is might encourage other contributors to form PR like this and seek similar instances to fix. Why do you think this PR is worth to fix?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
