Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3596#discussion_r21341088
  
    --- Diff: ec2/spark_ec2.py ---
    @@ -504,9 +504,9 @@ def get_existing_cluster(conn, opts, cluster_name, 
die_on_error=True):
             active = [i for i in res.instances if is_active(i)]
             for inst in active:
                 group_names = [g.name for g in inst.groups]
    -            if group_names == [cluster_name + "-master"]:
    +            if cluster_name + "-master" in group_names:
    --- End diff --
    
    Minor nit, but I think it's clearer to add parentheses here to make the 
operator precedence more clear.  I'm going to do this myself while merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to