hvanhovell commented on a change in pull request #23169: [SPARK-26103][SQL]
Limit the length of debug strings for query plans
URL: https://github.com/apache/spark/pull/23169#discussion_r249369278
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -591,6 +591,7 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]]
extends Product {
children.last.generateTreeString(
depth + 1, lastChildren :+ true, append, verbose, prefix, addSuffix,
maxFields)
}
+ append("")
Review comment:
Are you using the boolean returned by the append for control flow anywhere?
Let's remove it for the initial PR, we can always address this in a
follow-up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
