srowen commented on a change in pull request #23569: [SPARK-25713][SQL] -
adding copy for ColumnArray
URL: https://github.com/apache/spark/pull/23569#discussion_r249461375
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnarArray.java
##########
@@ -46,7 +47,33 @@ public int numElements() {
@Override
public ArrayData copy() {
Review comment:
The only problem I see with this is that it doesn't return a ColumnarArray.
I'm not sure if that's possible as ColumnVector doesn't implement a clone() or
copy() method, and maybe I'm missing reasons that's not sensible. So this might
be intentional. I don't see any rationale from whoever opened the JIRA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
