cloud-fan commented on a change in pull request #19788: [SPARK-9853][Core]
Optimize shuffle fetch of contiguous partition IDs
URL: https://github.com/apache/spark/pull/19788#discussion_r249468394
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java
##########
@@ -211,42 +211,58 @@ public ShuffleMetrics() {
private final String appId;
private final String execId;
private final int shuffleId;
- // An array containing mapId and reduceId pairs.
- private final int[] mapIdAndReduceIds;
+ // An array containing mapId, reduceId and numBlocks tuple
+ private int[] shuffleBlockIds;
- ManagedBufferIterator(String appId, String execId, String[] blockIds) {
+ ManagedBufferIterator(
+ String appId,
+ String execId,
+ String[] blockIds,
+ boolean fetchContinuousShuffleBlocksInBatch) {
this.appId = appId;
this.execId = execId;
String[] blockId0Parts = blockIds[0].split("_");
- if (blockId0Parts.length != 4 || !blockId0Parts[0].equals("shuffle")) {
+ if (!ExternalShuffleBlockResolver.isShuffleBlock(blockId0Parts)) {
Review comment:
According to the PR description, the server side will only get the normal
shuffle block id, do we really need to change the condition here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
