yucai commented on a change in pull request #19788: [SPARK-9853][Core] Optimize
shuffle fetch of contiguous partition IDs
URL: https://github.com/apache/spark/pull/19788#discussion_r249521604
##########
File path:
core/src/main/scala/org/apache/spark/serializer/SerializerManager.scala
##########
@@ -110,6 +110,7 @@ private[spark] class SerializerManager(
private def shouldCompress(blockId: BlockId): Boolean = {
blockId match {
case _: ShuffleBlockId => compressShuffle
+ case _: ArrayShuffleBlockId => compressShuffle
Review comment:
No, but `ShuffleBlockFetcherIterator` needs uncompress to detect corrupt.
```
var isStreamCopied: Boolean = false
try {
input = streamWrapper(arrayBlockId, in)
```
But I think I can use below to avoid this.
```
var isStreamCopied: Boolean = false
try {
input = streamWrapper(arrayBlockId.blockIds.head, in)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
