Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3050#discussion_r21348426
--- Diff: bin/spark-class ---
@@ -115,7 +115,7 @@ JAVA_VERSION=$("$RUNNER" -version 2>&1 | grep 'version'
| sed 's/.* version "\(.
if [ "$JAVA_VERSION" -ge 18 ]; then
JAVA_OPTS="$OUR_JAVA_OPTS"
--- End diff --
We probably need to add the Java option here, too, so that it works with
newer JDK versions. If you go through the `git blame` history, it looks like
this branch was added because`MaxPermSize` doesn't work on newer Java versions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
