mccheah commented on a change in pull request #23606: [SPARK-26666][SQL]
Support DSv2 overwrite and dynamic partition overwrite.
URL: https://github.com/apache/spark/pull/23606#discussion_r249614540
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -386,16 +385,64 @@ case class AppendData(
}
}
+/**
+ * Append data to an existing table.
+ */
+case class AppendData(
+ table: NamedRelation,
+ query: LogicalPlan,
+ isByName: Boolean) extends V2WriteCommand
+
object AppendData {
def byName(table: NamedRelation, df: LogicalPlan): AppendData = {
- new AppendData(table, df, true)
+ new AppendData(table, df, isByName = true)
}
def byPosition(table: NamedRelation, query: LogicalPlan): AppendData = {
- new AppendData(table, query, false)
+ new AppendData(table, query, isByName = false)
+ }
+}
+
+/**
+ * Overwrite data matching a filter in an existing table.
+ */
+case class OverwriteByExpression(
+ table: NamedRelation,
+ deleteExpr: Expression,
+ query: LogicalPlan,
+ isByName: Boolean) extends V2WriteCommand
+
+object OverwriteByExpression {
+ def byName(
+ table: NamedRelation, df: LogicalPlan, deleteExpr: Expression):
OverwriteByExpression = {
Review comment:
Is there a reason it's `df` here and `query` in `byPosition`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
