Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2853#discussion_r21349941
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala ---
@@ -73,9 +73,8 @@ class BlockManagerMasterActor(val isLocal: Boolean, conf:
SparkConf, listenerBus
case UpdateBlockInfo(
blockManagerId, blockId, storageLevel, deserializedSize, size,
tachyonSize) =>
- // TODO: Ideally we want to handle all the message replies in
receive instead of in the
- // individual private methods.
- updateBlockInfo(blockManagerId, blockId, storageLevel,
deserializedSize, size, tachyonSize)
+ sender ! updateBlockInfo(
+ blockManagerId, blockId, storageLevel, deserializedSize, size,
tachyonSize)
--- End diff --
Super-minor nit, but could you change this line so that it's indented two
spaces from the previous one instead of four?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
