imatiach-msft commented on a change in pull request #21632:
[SPARK-19591][ML][MLlib] Add sample weights to decision trees
URL: https://github.com/apache/spark/pull/21632#discussion_r249637983
##########
File path:
mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala
##########
@@ -167,7 +167,7 @@ class DecisionTreeSuite extends SparkFunSuite with
MLlibTestSparkContext {
val rdd = sc.parallelize(arr)
val strategy = new Strategy(Classification, Entropy, maxDepth = 3,
numClasses = 2, maxBins = 100)
- val metadata = DecisionTreeMetadata.buildMetadata(rdd.map(_.asML),
strategy)
+ val metadata =
DecisionTreeMetadata.buildMetadata(rdd.map(_.asML.toInstance), strategy)
Review comment:
I can update it if you prefer, it would indeed decrease the number of
changes in the PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
