cloud-fan commented on a change in pull request #23566: [SPARK-26637][SQL]
Makes GetArrayItem nullability more precise
URL: https://github.com/apache/spark/pull/23566#discussion_r249639347
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ComplexTypeSuite.scala
##########
@@ -59,6 +59,37 @@ class ComplexTypeSuite extends SparkFunSuite with
ExpressionEvalHelper {
checkEvaluation(GetArrayItem(nestedArray, Literal(0)), Seq(1))
}
+ test("SPARK-26637 handles GetArrayItem nullability correctly when input
array size is constant") {
+ // CreateArray case
+ val a = AttributeReference("a", IntegerType, nullable = false)()
+ val b = AttributeReference("b", IntegerType, nullable = true)()
+ val array = CreateArray(a :: b :: Nil)
+ assert(!GetArrayItem(array, Literal(0)).nullable)
+ assert(GetArrayItem(array, Literal(1)).nullable)
+ assert(!GetArrayItem(array, Subtract(Literal(2), Literal(2))).nullable)
+ assert(GetArrayItem(array, AttributeReference("ordinal",
IntegerType)()).nullable)
+
+ // GetArrayStructFields case
+ val f1 = StructField("a", IntegerType, nullable = false)
+ val f2 = StructField("b", IntegerType, nullable = true)
+ val structType = StructType(f1 :: f2 :: Nil)
+ val c = AttributeReference("c", structType, nullable = false)()
+ val stArray1 = GetArrayStructFields(CreateArray(c :: Nil), f1, 0, 2,
containsNull = f1.nullable)
Review comment:
`containsNull` should be `c.nullable`, according to the logic in
`ExtractValue.apply`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
