cloud-fan commented on a change in pull request #23569: [SPARK-25713][SQL] -
adding copy for ColumnArray
URL: https://github.com/apache/spark/pull/23569#discussion_r249640796
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnarArray.java
##########
@@ -46,7 +47,33 @@ public int numElements() {
@Override
public ArrayData copy() {
Review comment:
I think it's no harm to implement copy, as we also did it for
`ColumnarRow.copy`. But we can do better here: if the data type is primitive
type like int, we can `UnsafeArrayData.fromPrimitiveArray(toIntArray())`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
