HeartSaVioR commented on a change in pull request #23609: [SPARK-26379][SS] Fix
issue on adding current_timestamp/current_date to streaming query
URL: https://github.com/apache/spark/pull/23609#discussion_r249712482
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala
##########
@@ -1079,6 +1079,42 @@ class StreamSuite extends StreamTest {
assert(query.exception.isEmpty)
}
}
+
+ Seq(true, false).foreach { useV2Sink =>
Review comment:
RIght. That was to minimize the code, but I guess only some lines will be
added and it will become easier to test so better to apply your suggestion.
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
