ayudovin commented on a change in pull request #23569: [SPARK-25713][SQL] -
adding copy for ColumnArray
URL: https://github.com/apache/spark/pull/23569#discussion_r249765881
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnarArray.java
##########
@@ -46,7 +48,25 @@ public int numElements() {
@Override
public ArrayData copy() {
- throw new UnsupportedOperationException();
+ DataType dt = data.dataType();
+
+ if (dt instanceof BooleanType) {
+ return UnsafeArrayData.fromPrimitiveArray(toBooleanArray());
+ } else if (dt instanceof ByteType) {
+ return UnsafeArrayData.fromPrimitiveArray(toByteArray());
+ } else if (dt instanceof ShortType) {
+ return UnsafeArrayData.fromPrimitiveArray(toShortArray());
+ } else if (dt instanceof IntegerType) {
+ return UnsafeArrayData.fromPrimitiveArray(toIntArray());
+ } else if (dt instanceof LongType) {
+ return UnsafeArrayData.fromPrimitiveArray(toLongArray());
+ } else if (dt instanceof FloatType) {
+ return UnsafeArrayData.fromPrimitiveArray(toFloatArray());
+ } else if (dt instanceof DoubleType) {
+ return UnsafeArrayData.fromPrimitiveArray(toDoubleArray());
+ } else {
+ throw new RuntimeException("Not implemented. " + dt);
Review comment:
@cloud-fan, Are you talking about the handling of `StringType`,
`DecimalType` and `TimestampType`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
