MaxGekk commented on a change in pull request #23597: [SPARK-26653][SQL] Use
Proleptic Gregorian calendar in parsing JDBC lower/upper bounds
URL: https://github.com/apache/spark/pull/23597#discussion_r249808238
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
##########
@@ -174,10 +174,21 @@ private[sql] object JDBCRelation extends Logging {
(dialect.quoteIdentifier(column.name), column.dataType)
}
- private def toInternalBoundValue(value: String, columnType: DataType): Long
= columnType match {
- case _: NumericType => value.toLong
- case DateType => DateTimeUtils.fromJavaDate(Date.valueOf(value)).toLong
- case TimestampType =>
DateTimeUtils.fromJavaTimestamp(Timestamp.valueOf(value))
+ private def toInternalBoundValue(
+ value: String,
+ columnType: DataType,
+ timeZoneId: String): Long = {
+ def parse[T](f: UTF8String => Option[T]): T = {
+ f(UTF8String.fromString(value)).getOrElse {
Review comment:
There is a function there
https://github.com/apache/spark/pull/23541/files#diff-9847f5cef7cf7fbc5830fbc6b779ee10R1555
which applies `UTF8String.fromString` and `f: F8String => Option[T]` but this
is the only common code. Do you think is it worth to extract the common code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
