srowen commented on a change in pull request #23445: [SPARK-26530]Validate
heartheat arguments in HeartbeatReceiver
URL: https://github.com/apache/spark/pull/23445#discussion_r249818351
##########
File path: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala
##########
@@ -79,13 +79,19 @@ private[spark] class HeartbeatReceiver(sc: SparkContext,
clock: Clock)
private val executorTimeoutMs =
sc.conf.getTimeAsMs("spark.storage.blockManagerSlaveTimeoutMs",
Review comment:
This can use STORAGE_BLOCKMANAGER_SLAVE_TIMEOUT now; it does already in
`master`. while technically you don't need to rebase this PR, it might be
useful here so that we can see the current state of `master` vs your changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
