srowen commented on a change in pull request #23559: [SPARK-26630][SQL] Fix
ClassCastException in TableReader while creating HadoopRDD
URL: https://github.com/apache/spark/pull/23559#discussion_r249823856
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala
##########
@@ -311,6 +317,29 @@ class HadoopTableReader(
// Only take the value (skip the key) because Hive works only with values.
rdd.map(_._2)
}
+
+ /**
+ * Creates a NewHadoopRDD based on the broadcasted HiveConf and other job
properties that will be
+ * applied locally on each slave.
+ */
+ private def createNewHadoopRdd(tableDesc: TableDesc, path: String):
RDD[Writable] = {
Review comment:
The two new methods have the same arguments and call
tableDesc.getInputFileFormatClass and rdd.map(_._2); not a big deal, more
concerned with keeping code locality. I don't feel strongly about it. How about
importing these Hadoop classes with a rename, rather than use the fully
qualified names several times?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
