Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3375#discussion_r21354115
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashOuterJoin.scala
---
@@ -68,62 +68,59 @@ case class HashOuterJoin(
@transient private[this] lazy val DUMMY_LIST = Seq[Row](null)
@transient private[this] lazy val EMPTY_LIST = Seq.empty[Row]
+ @transient private[this] lazy val joinedRow = new JoinedRow()
--- End diff --
Is it safe to move mutable structures like this out into the class? I
guess I'm not super clear on how deserialization of the same task executing on
multiple threads concurrently occurs. I think this might work, but if we ever
get more clever I think it will lead to some very confusing bugs. Therefore, I
think its probably better to create new ones inside of the function like before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
