HeartSaVioR commented on a change in pull request #23260: [SPARK-26311][CORE]
New feature: apply custom log URL pattern for executor log URLs in SHS
URL: https://github.com/apache/spark/pull/23260#discussion_r250028411
##########
File path:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
##########
@@ -291,6 +292,159 @@ class FsHistoryProviderSuite extends SparkFunSuite with
BeforeAndAfter with Matc
}
}
+ test("Handling executor log url without renewing") {
Review comment:
Actually I prefer grouping similar tests as same prefix as well as enough
long explanation to make test name self-describing, but no strong opinion, and
I also agree it may make hard to differentiate them. I'll go through test names
and renaming them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
