peter-toth commented on a change in pull request #23531: [SPARK-24497][SQL] 
Support recursive SQL query
URL: https://github.com/apache/spark/pull/23531#discussion_r250180394
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/inputs/recursion.sql
 ##########
 @@ -0,0 +1,291 @@
+-- List of configuration the test suite is run against:
 
 Review comment:
   I think LIMIT pushdown is a good idea as `RecursiveTable` is kind of an 
`Union` but a constant limit in the recursive term will not stop the recursion.
   I've just added a commit where I push the limit through `RecursiveTableExec` 
which is useful for limiting the anchor especially. But I also record the limit 
into `RecursiveTableExec` so as to insert adjusted `GlobalLimitExec`s into each 
iteration of the recursive term.
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to