vanzin commented on a change in pull request #23618: [SPARK-26694][CORE]
Progress bar should be enabled by default for spark-shell
URL: https://github.com/apache/spark/pull/23618#discussion_r250345574
##########
File path: core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala
##########
@@ -478,12 +478,19 @@ class SparkSubmitSuite
val clArgs1 = Seq("--class", "org.apache.spark.repl.Main", "spark-shell")
val appArgs1 = new SparkSubmitArguments(clArgs1)
val (_, _, conf1, _) = submit.prepareSubmitEnvironment(appArgs1)
+
conf1.get(UI_SHOW_CONSOLE_PROGRESS) should be (true)
+ val sc1 = new SparkContext(conf1)
+ assert(sc1.progressBar.isDefined)
+ sc1.stop()
Review comment:
You need `try..finally` for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
