HyukjinKwon edited a comment on issue #20691: [SPARK-18161] [Python] Update cloudpickle to v0.6.1 URL: https://github.com/apache/spark/pull/20691#issuecomment-457075552 @inpefess, mind if I ask to double check together? We should take a look at: 1. https://github.com/irmen/Pyrolite/blob/55941dbf5d8e03381a5393a190062ca4447e21d0/java/src/main/java/net/razorvine/pickle/Unpickler.java#L289-L327 (4.13 that's we're currently using) 2. https://www.python.org/dev/peps/pep-3154/ 3. ```python import pickle import pickletools print(pickletools.dis(pickle.dumps(obj, protocol=3))) ``` vs ```python import pickle import pickletools print(pickletools.dis(pickle.dumps(obj, protocol=4))) ``` 4. If we need, we should upgrade this library (if that's related with protocol 3 -> 4 change). https://github.com/irmen/Pyrolite/releases
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
