rvesse commented on issue #23613: [SPARK-26687][K8S] Fix handling of custom Dockerfile paths URL: https://github.com/apache/spark/pull/23613#issuecomment-457167911 @vanzin So actually there is a practical reason we copy the `resource-managers/kubernetes/docker/src/main/dockerfiles` directory into the build context. We do need to package up the `entrypoint.sh` script which is assumed to be found at `kubernetes/dockerfiles/spark/entrypoint.sh` in the build context. So by removing the copy from the creation of the temporary build context directory breaks developer builds. And as we don't won't to preclude needing additional scripts or files for the Docker image contents in future so it seems safest to leave the copy in place as-is. This also avoids further complicating the script because if I remove the copy I also have to add extra logic to set the default base Dockerfile path depending on whether we're in a dev/release build. Plus I'd need to still copy in the entry point script or otherwise parameterise it's location via build arguments.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
