srowen commented on a change in pull request #23638: [SPARK-26713][CORE]
Release pipe IO threads in PipedRDD when task is finished
URL: https://github.com/apache/spark/pull/23638#discussion_r250604406
##########
File path: core/src/main/scala/org/apache/spark/rdd/PipedRDD.scala
##########
@@ -156,7 +157,34 @@ private[spark] class PipedRDD[T: ClassTag](
out.close()
}
}
- }.start()
+ }
+ stdinWriterThread.start()
+
+ def cleanUpIOThreads(): Unit = {
+ if (proc.isAlive) {
+ proc.destroy()
+ }
+ if (stdinWriterThread.isAlive) {
+ stdinWriterThread.stop()
Review comment:
.stop() has been deprecated and 'dangerous' for a long time. You can
interrupt the threads though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
