gaborgsomogyi commented on a change in pull request #23499: [SPARK-26254][CORE]
Extract Hive + Kafka dependencies from Core.
URL: https://github.com/apache/spark/pull/23499#discussion_r250651220
##########
File path:
core/src/test/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManagerSuite.scala
##########
@@ -30,86 +46,15 @@ class HadoopDelegationTokenManagerSuite extends
SparkFunSuite {
val manager = new HadoopDelegationTokenManager(new SparkConf(false),
hadoopConf, null)
assert(manager.isProviderLoaded("hadoopfs"))
assert(manager.isProviderLoaded("hbase"))
- assert(manager.isProviderLoaded("hive"))
- assert(manager.isProviderLoaded("kafka"))
- }
-
- test("disable hive credential provider") {
- val sparkConf = new
SparkConf(false).set("spark.security.credentials.hive.enabled", "false")
- val manager = new HadoopDelegationTokenManager(sparkConf, hadoopConf, null)
- assert(manager.isProviderLoaded("hadoopfs"))
- assert(manager.isProviderLoaded("hbase"))
- assert(!manager.isProviderLoaded("hive"))
- assert(manager.isProviderLoaded("kafka"))
+ // This checks that providers are loaded independently and they have no
effect on each other
+ assert(!manager.isProviderLoaded("throw"))
Review comment:
Yep, that's a really important feature not to kill the whole security.
Adding...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
