HeartSaVioR edited a comment on issue #23634: [SPARK-26154][SS] Streaming 
left/right outer join should not return outer nulls for already matched rows
URL: https://github.com/apache/spark/pull/23634#issuecomment-457405492
 
 
   > I think it's incorrect to evict R1 if we aren't also evicting all rows in 
L which R1 could have matched with.
   
   My understanding for storing rows in state is for matching against new rows, 
not for concerning previous status. If we have to keep rows in right side due 
to joined left side rows are not evicted (may end up with also waiting for 5 
seconds in above case), we end up unnecessary storing rows for right side 
(which cannot be matched against new rows in left side) which can be just 
replaced with matched flag.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to