advancedxy commented on a change in pull request #23638: [SPARK-26713][CORE]
Interrupt pipe IO threads in PipedRDD when task is finished
URL: https://github.com/apache/spark/pull/23638#discussion_r250854498
##########
File path: core/src/main/scala/org/apache/spark/rdd/PipedRDD.scala
##########
@@ -185,6 +211,10 @@ private[spark] class PipedRDD[T: ClassTag](
}
private def cleanup(): Unit = {
+ // interrupt the stdin writer thread, so the stdin writer thread for
ShuffledRDD could be
Review comment:
Not necessary. This will happen first if command is failed/exited, then
interrupt in task completion listener is redundant.
This is my initial fix. Will remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
