viirya commented on a change in pull request #23628: [SPARK-26702][TEST] Create
a test trait for Parquet and Orc test
URL: https://github.com/apache/spark/pull/23628#discussion_r250873312
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala
##########
@@ -270,7 +270,10 @@ abstract class OrcQueryTest extends OrcTest {
test("appending") {
val data = (0 until 10).map(i => (i, i.toString))
spark.createDataFrame(data).toDF("c1", "c2").createOrReplaceTempView("tmp")
- withOrcTable(data, "t") {
+ // The test closure has side effect that changes table 't'. Running it
without resetting
+ // the table data twice with vectorized=true and false will fail at the
second time.
+ // Since it cares about inserting, we only do testing for vectorized=false.
Review comment:
Ok. Because the test closure has side effect, I can't use `withOrcTable` for
it. I slightly change the test but keep original semantic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
