mgaido91 commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r250916002
########## File path: sql/core/src/test/resources/sql-tests/inputs/recursion.sql ########## @@ -0,0 +1,291 @@ +-- List of configuration the test suite is run against: Review comment: > I still need the number of rows limit as a field in RecursiveTable to stop the recursion if the recursion generated enough rows. yes, I think it is not trivial at all finding another way. I was thinking also about creating a custom RDD for this case, but it is hard since we cannot know in advance how may partitions there will be unless we do the count as it is done here. I'd keep it as it is for the moment and we can eventually get back to this in a followup PR if a better idea comes up IMHO. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
