maropu commented on a change in pull request #23641: [SPARK-26719][SQL] Get rid of java.util.Calendar in DateTimeUtils URL: https://github.com/apache/spark/pull/23641#discussion_r250997116
########## File path: docs/sql-migration-guide-upgrade.md ########## @@ -95,6 +95,8 @@ displayTitle: Spark SQL Upgrading Guide - Since Spark 3.0, the JDBC options `lowerBound` and `upperBound` are converted to TimestampType/DateType values in the same way as casting strings to TimestampType/DateType values. The conversion is based on Proleptic Gregorian calendar, and time zone defined by the SQL config `spark.sql.session.timeZone`. In Spark version 2.4 and earlier, the conversion is based on the hybrid calendar (Julian + Gregorian) and on default system time zone. + - Since Spark 3.0, the `date_trunc`, `from_utc_timestamp`, `to_utc_timestamp`, `unix_timestamp` functions use java.time API based on Proleptic Gregorian calendar. In Spark version 2.4 and earlier, the hybrid calendar (Julian + Gregorian) is used for the same purpose. Results of the functions returned by Spark 3.0 and previous versions can be different for dates before October 15, 1582 (Gregorian). Review comment: nit: ...`to_utc_timestamp`, and `unix_timestamp` functions... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
