jose-torres commented on issue #23612: [SPARK-26686][SS] Remove unnecessary KafkaSourceProvider parameter lowercase conversion URL: https://github.com/apache/spark/pull/23612#issuecomment-457719414 I'm not sure I understand why this change is valuable, but I agree that it looks valid, and I'd argue that DataSourceOptions can/does/should guarantee it canonicalizes the case-insensitive map to something that implementations can use as a raw Map[String, String] if they want. Are there existing tests which verify that parameters are passed through to Kafka case-insensitively? I'm not necessarily comfortable just trusting generic unit tests, since failing to pass parameters from our test setup might not cause observable problems.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
