liupc commented on a change in pull request #23650: [SPARK-26728]Make
rdd.unpersist blocking configurable
URL: https://github.com/apache/spark/pull/23650#discussion_r251191524
##########
File path: core/src/main/scala/org/apache/spark/rdd/RDD.scala
##########
@@ -209,13 +210,14 @@ abstract class RDD[T: ClassTag](
*/
def cache(): this.type = persist()
+ private val unpersistBlocking = conf.get(RDD_UNPERSIST_BLOCKING)
/**
* Mark the RDD as non-persistent, and remove all blocks for it from memory
and disk.
*
* @param blocking Whether to block until all blocks are deleted.
* @return This RDD.
*/
- def unpersist(blocking: Boolean = true): this.type = {
+ def unpersist(blocking: Boolean = unpersistBlocking): this.type = {
Review comment:
@viirya In a production environment, the configs and packages are always
managed by gray release systems, so a config is needed rather than the explicit
parameter.
If you agree, it would be better to make the blocking parameter default to
`false` as @srowen suggested, and it's what I expected. I proposed to make this
blocking parameter configurable is afraid of the side effect of this changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
