srowen commented on a change in pull request #23645: [SPARK-26725][TEST] Fix
the input values of UnifiedMemoryManager constructor in test suites
URL: https://github.com/apache/spark/pull/23645#discussion_r251201995
##########
File path: core/src/main/scala/org/apache/spark/memory/MemoryManager.scala
##########
@@ -41,6 +41,9 @@ private[spark] abstract class MemoryManager(
onHeapStorageMemory: Long,
onHeapExecutionMemory: Long) extends Logging {
+ require(onHeapStorageMemory > 0, "onHeapStorageMemory must be > 0")
Review comment:
Hm, on second thought, there's not really a reason this must be positive.
It's at least possible that no memory is immune from eviction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
