rdblue commented on a change in pull request #23606: [SPARK-26666][SQL] Support 
DSv2 overwrite and dynamic partition overwrite.
URL: https://github.com/apache/spark/pull/23606#discussion_r251259893
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ##########
 @@ -159,6 +159,7 @@ class Analyzer(
     Batch("Resolution", fixedPoint,
       ResolveTableValuedFunctions ::
       ResolveRelations ::
+      ResolveOutputRelation ::
 
 Review comment:
   I had to move this higher in the batch so that outputs were resolved before 
the overwrite expression (see analysis tests for `OverwriteByExpression`). 
Otherwise, the expression would be resolved against the overwrite's child query.
   
   Another approach is to change how the expression's attributes are resolved 
to use the table instead of the query. But changing expression resolution to 
use something other than children seemed too intrusive.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to